Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of restore-keys #5

Open
DMRobertson opened this issue May 6, 2022 · 0 comments
Open

Make use of restore-keys #5

DMRobertson opened this issue May 6, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@DMRobertson
Copy link
Contributor

If we don't have a cache-hit for the poetry-managed venv, we'll end up recreating it from scratch. We could save a little bit of time by restoring from a different cache with a similar name.

We could probably make use of restore-keys here:

- name: Restore/cache poetry venv
id: poetry-venv-cache
uses: actions/cache@v2
with:
path: ${{ steps.poetry-venvs.outputs.dir }}
key: poetry-venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/poetry.lock') }}-${{ inputs.extras }}

Probably restore-keys: poetry-venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}?

Would need to test it by making a small change to the lockfile and seeing if we modify a cached venv rather than recreating it from scratch. Or we could just make the change and YOLO it.

Either way, it's one for the wishlist.

@DMRobertson DMRobertson added the enhancement New feature or request label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant