Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some legacy methods with dom methods #447

Merged
merged 4 commits into from Jan 5, 2023
Merged

Replace some legacy methods with dom methods #447

merged 4 commits into from Jan 5, 2023

Conversation

aringenbach
Copy link
Contributor

@aringenbach aringenbach commented Jan 4, 2023 •
edited

  • Removed another legacy function
  • Add the capability for removing container that only contains a ZWSP node, instead of leaving them empty.
  • Move slicing list item to dom methods

@aringenbach aringenbach changed the title Replace legacy remove_list_item with dom method Replace some legacy methods with dom methods Jan 4, 2023
@alunturner
Copy link
Contributor

Just the one comment which isn't a required change. Always like PRs that reduce the amount of code!

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aringenbach aringenbach merged commit 1de5225 into main Jan 5, 2023
@aringenbach aringenbach deleted the aringenbach/replace_legacy_remove_list_item branch January 5, 2023 10:57
@aringenbach aringenbach mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alunturner alunturner alunturner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aringenbach @alunturner