Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remove link and get link methods #446

Merged
merged 1 commit into from Jan 5, 2023
Merged

Add remove link and get link methods #446

merged 1 commit into from Jan 5, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jan 4, 2023 •
edited

Add bindings to the removeLinks method and an access to the current selected link

@florianduros florianduros marked this pull request as ready for review January 4, 2023 14:18
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

alunturner
alunturner approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@alunturner alunturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@florianduros florianduros merged commit 64fef26 into main Jan 5, 2023
@florianduros florianduros deleted the feat/link-edition branch January 5, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alunturner alunturner alunturner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@florianduros @alunturner