Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow building from source #35

Open
selfisekai opened this issue Mar 6, 2024 · 2 comments · May be fixed by #36
Open

allow building from source #35

selfisekai opened this issue Mar 6, 2024 · 2 comments · May be fixed by #36

Comments

@selfisekai
Copy link

the module currently cannot be built locally, without downloading prebuilt binaries off github.

this should be available at least as a fallback if prebuilds are not available, or with --build-from-source/npm_config_build_from_source (analogical to node-pre-gyp)

@Hywan
Copy link
Member

Hywan commented Mar 11, 2024

Thanks for the suggestion. I don’t know how to do that though. Do you have an idea?

@selfisekai
Copy link
Author

remove src, Cargo.toml, Cargo.lock, build.rs from .npmignore, change the npm postinstall script to something that either downloads the binary or builds it. node download-lib.js || napi build --release? (with an early exit in download-lib.js to always fail when source build wanted)

@selfisekai selfisekai linked a pull request Mar 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants