Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup widget auth popup not handled properly in Element Desktop #742

Open
justinbot opened this issue Mar 7, 2023 · 0 comments
Open

Setup widget auth popup not handled properly in Element Desktop #742

justinbot opened this issue Mar 7, 2023 · 0 comments
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@justinbot
Copy link
Contributor

justinbot commented Mar 7, 2023

When adding a Slack Workspace in the setup widget, a new window is opened to auth with Slack.
We then wait for the popup to close before refreshing workspaces.

This works in Element Web, but in Element Desktop the popup opens in your web browser so the widget just thinks the popup didn't open:

Screenshot 2023-03-07 at 2 21 02 PM

Authorizing with Slack still works, however you have to close and open the widget to see the new Workspace.
We should implement this in a way that doesn't require interacting with the popup (such as polling workspaces), and fix the popup warning message if possible.

@justinbot justinbot added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. labels Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Development

No branches or pull requests

1 participant