Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onUserQuery should not swallow exception #421

Open
tak-hntlabs opened this issue Jul 20, 2022 · 0 comments
Open

onUserQuery should not swallow exception #421

tak-hntlabs opened this issue Jul 20, 2022 · 0 comments
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@tak-hntlabs
Copy link

Describe the bug
In bridge.ts, the method Bridge.onUserQuery swallows exceptions and logs a message. Consequently AppService.onGetUsers sends back a http 200 to the dendrite server. The server assumes that the user query succeeded. Eventually it ran into some other issues.

Expected behavior
Propose removing try..catch in Bridge.onUserQuery. Let AppService catch the exception and send back a 400 status. The dendrite / synapse server can handle it as appropriate.
@tak-hntlabs tak-hntlabs mentioned this issue Jul 20, 2022
Closed
@Half-Shot Half-Shot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Half-Shot @tak-hntlabs