Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turning usernames into mxids loses information #346

Open
tadzik opened this issue Jul 30, 2021 · 0 comments
Open

Turning usernames into mxids loses information #346

tadzik opened this issue Jul 30, 2021 · 0 comments
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@tadzik
Copy link
Contributor

tadzik commented Jul 30, 2021

Describe the bug
The way we encode usernames, makes it impossible to losslessly decode them later: it's impossible to tell if a =201d was originally a 1d or a ”. This could result in duplicate mxids for otherwise distinct remote users, but also prevents us from turning MXids into remote IDs reliably (see matrix-org/matrix-bifrost#268).
tadzik added a commit to matrix-org/matrix-bifrost that referenced this issue Jul 30, 2021
@tadzik
Fix not being able to DM users with non-ascii usernames
beffa17 
Remote usernames with multibyte characters in them currently get encoded
into mxids in a way that may result in information loss
(see matrix-org/matrix-appservice-bridge#346).

This makes it impossible to reach some users by MXID alone, so this
makes it lookup the MXID in the user store, which contains the original,
unmangled username.
@tadzik tadzik mentioned this issue Jul 30, 2021
Open
tadzik added a commit to matrix-org/matrix-bifrost that referenced this issue Jul 30, 2021
@tadzik
Fix not being able to DM users with non-ascii usernames
0f81080 
Remote usernames with multibyte characters in them currently get encoded
into mxids in a way that may result in information loss
(see matrix-org/matrix-appservice-bridge#346).

This makes it impossible to reach some users by MXID alone, so this
makes it lookup the MXID in the user store, which contains the original,
unmangled username.
tadzik added a commit to matrix-org/matrix-bifrost that referenced this issue Jul 30, 2021
@tadzik
Fix not being able to DM users with non-ascii usernames
3450988 
Remote usernames with multibyte characters in them currently get encoded
into mxids in a way that may result in information loss
(see matrix-org/matrix-appservice-bridge#346).

This makes it impossible to reach some users by MXID alone, so this
makes it lookup the MXID in the user store, which contains the original,
unmangled username.

Fixes GH-268.
tadzik added a commit to matrix-org/matrix-bifrost that referenced this issue Aug 2, 2021
@tadzik
Fix not being able to DM users with non-ascii usernames
d83aed1 
Remote usernames with multibyte characters in them currently get encoded
into mxids in a way that may result in information loss
(see matrix-org/matrix-appservice-bridge#346).

This makes it impossible to reach some users by MXID alone, so this
makes it lookup the MXID in the user store, which contains the original,
unmangled username.

Fixes GH-268.
@Half-Shot Half-Shot added the bug label Aug 3, 2021
@Half-Shot Half-Shot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. S-Minor Impairs non-critical functionality or suitable workarounds exist and removed bug labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tadzik @Half-Shot