Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception class to pytest.warns calls #24113

Merged
merged 1 commit into from Oct 7, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 7, 2022

PR Summary

This is failing on current pytest.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added this to the v3.6.1 milestone Oct 7, 2022
This is failing on current pytest.
Copy link
Contributor

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a match for the two without one?

@QuLogic
Copy link
Member Author

QuLogic commented Oct 7, 2022

Those are checked in the above test_register_cmap, I think, so I didn't add the match, but could.

@timhoffm timhoffm merged commit 4965500 into matplotlib:main Oct 7, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 7, 2022
@QuLogic QuLogic deleted the warn-types branch October 7, 2022 08:09
QuLogic added a commit that referenced this pull request Oct 7, 2022
…113-on-v3.6.x

Backport PR #24113 on branch v3.6.x (Add exception class to pytest.warns calls)
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants