Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: remove sample_plots from tutorials #21640

Merged
merged 2 commits into from Nov 15, 2021

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Nov 15, 2021

PR Summary

Removes https://matplotlib.org/devdocs/tutorials/introductory/sample_plots.html#sphx-glr-tutorials-introductory-sample-plots-py and redirects it to https://matplotlib.org/devdocs/plot_types/index.html I think most of the info is redundant.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@jklymak jklymak added the Documentation: website layout/behavior/styling changes label Nov 15, 2021
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the removed page is redundant - not fully covered by the page it's redirected from, but there's plenty of other stuff in the example gallery for what's missed.

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the intent of sample_plots is better served by plot_types.

@timhoffm timhoffm added this to the v3.5.1 milestone Nov 15, 2021
@timhoffm timhoffm merged commit aae1386 into matplotlib:main Nov 15, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 15, 2021
@QuLogic QuLogic modified the milestones: v3.5.1, v3.5.0 Nov 15, 2021
QuLogic added a commit that referenced this pull request Nov 15, 2021
…640-on-v3.5.x

Backport PR #21640 on branch v3.5.x (DOC: remove sample_plots from tutorials)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: website layout/behavior/styling changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants