Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass integers to wx.Size. #19052

Merged
merged 1 commit into from Dec 16, 2020
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Dec 1, 2020

PR Summary

Fixes test failure on Python 3.10, https://bugzilla.redhat.com/show_bug.cgi?id=1902382

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added the GUI: wx label Dec 1, 2020
@QuLogic QuLogic added this to the v3.4.0 milestone Dec 1, 2020
@tacaswell
Copy link
Member

Why ceil instead of floor?

@anntzer
Copy link
Contributor

anntzer commented Dec 4, 2020

Why ceil instead of floor?

(It would be nice to document once and for all how floating-point canvas sizes (which can legitimately occur e.g. with vector backends) are supposed to be handled by backends that only support integer sizes (typically raster backends).)

@QuLogic
Copy link
Member Author

QuLogic commented Dec 4, 2020

Because that's what's already done here:

FigureCanvasBase.__init__(self, figure)
w, h = map(math.ceil, figure.bbox.size)
# Set preferred window size hint - helps the sizer, if one is connected
wx.Panel.__init__(self, parent, id, size=wx.Size(w, h))

@tacaswell tacaswell merged commit e03d956 into matplotlib:master Dec 16, 2020
@QuLogic QuLogic deleted the wx-int branch December 16, 2020 19:56
@QuLogic
Copy link
Member Author

QuLogic commented Jan 27, 2021

@meeseeksdev backport to v3.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants