Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase heading level for 3.3 What's New #17942

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jul 15, 2020

PR Summary

When I added sections, that dropped down all the headings, and made them a bit difficult to differentiate:
image

Moving everything up one makes headings a bit more obvious:

image

PR Checklist

  • [N/A] Has Pytest style unit tests
  • [N/A] Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

It seems that sphinx-gallery adds a path to this directly, so the
trailing slash is needed to create the correct links.
@QuLogic QuLogic added this to the v3.3.0 milestone Jul 15, 2020
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self merge on green.

@QuLogic QuLogic merged commit cea02d3 into matplotlib:master Jul 16, 2020
@QuLogic QuLogic deleted the whatsnew-heading branch July 16, 2020 02:29
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 16, 2020
QuLogic added a commit that referenced this pull request Jul 16, 2020
…942-on-v3.3.x

Backport PR #17942 on branch v3.3.x (Increase heading level for 3.3 What's New)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants