correct minor typo and bumped atomic-polyfill #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jqnatividad
changed the title
|
bors r+ |
|
Build succeeded: |
|
released as https://crates.io/crates/once_cell/1.13.1 |
|
FYI, this was a breaking change for users who use the atomic-polyfill feature. (atomic-polyfill itself is not used in the once_cell public API, but the mechanism to implement a critical session implementation in the atomic-polyfill depends on versions of the atomic-polyfill and the critical-section (used in atomic-polyfill), so this can cause a compile error. I can provide reproduction if needed.) That said, I think this breaking change is justified because atomic-polyfill 1.0 has mitigated/fixed several soundness issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.