Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make initial loading indication more prominent for table pages #3473

Open
pavish opened this issue Mar 4, 2024 · 1 comment · May be fixed by #3602
Open

Make initial loading indication more prominent for table pages #3473

pavish opened this issue Mar 4, 2024 · 1 comment · May be fixed by #3602
Labels
help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@pavish
Copy link
Member

pavish commented Mar 4, 2024

Problem

  • When the table page loads, there's an empty view which gives an impression that there's something wrong with the app.
  • The loading indication is at the bottom right and it's not prominent to the user.
Screen.Recording.2024-03-04.at.1.15.42.PM.mov

Proposed solution

  • Present a more prominent loading indication in the center of the page.
@pavish pavish added type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory needs: product approval It's not yet clear that this issue will actually improve Mathesar from a user's perspective needs: ux design labels Mar 4, 2024
@pavish pavish added this to the Backlog milestone Mar 4, 2024
@seancolsen seancolsen added help wanted Community contributors can implement this ready Ready for implementation and removed needs: product approval It's not yet clear that this issue will actually improve Mathesar from a user's perspective needs: ux design labels Mar 4, 2024
@seancolsen
Copy link
Contributor

seancolsen commented Mar 4, 2024

Thanks for reporting this, @pavish.

  • I'm removing needs: product approval because I don't imagine that anyone would object to adding a loading indicator.

  • I'm removing needs: ux design because I think this is something that we can fairly easily improvise.

  • Regarding design, I suggest that we add a large loading spinner that appears within the table area, near the top, and horizontally centered.

    As precedent, here are some similar loading spinners that we have:

    • Within the record selector:

      image

    • Within the import preview

      image

    • On the record page:

      image

    Notice that we have some inconsistency in the size and color of these loading spinners. It might be nice to fix that by adding a LargeSpinner component that we use in cases like this. But I would consider that a very low priority — something that doesn't necessarily need to be done along with adding a loading spinner to the table page.

  • To me everything here seems straightforward, and this issue seems worth of moving forward, so I'm marking it as ready.

  • Because I think this would be fairly easy, I'm also marking it as help wanted.

@InosRahul InosRahul linked a pull request May 18, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants