Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to get_element_profile #2818

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Jan 26, 2023

Minor fixes to the return types of get_element_profile and electrode

get_element_profile fix:
The entries returned is given as dict_keys but that's rarely what people want.

  • Return a list of entries instead.
  • Also return the critical composition, which is usually useful information.

electrode fixes:

  • Linting on some docs
  • require framework formula for the from_steps constructor.

Unverified

This user has not yet uploaded their public signing key.
return type
@coveralls
Copy link

coveralls commented Jan 26, 2023

Coverage Status

Coverage: 78.163% (-0.7%) from 78.873% when pulling 35ffd5e on jmmshn:patch_profil into 8f5a6f5 on materialsproject:master.

@jmmshn jmmshn marked this pull request as ready for review January 26, 2023 22:01
jmmshn and others added 4 commits January 26, 2023 14:40

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Unverified

This user has not yet uploaded their public signing key.
@janosh
Copy link
Member

janosh commented Jan 30, 2023

Thanks @jmmshn! 👍

@janosh janosh enabled auto-merge (squash) January 30, 2023 00:06
@janosh janosh merged commit 809685b into materialsproject:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants