Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed deserialization of phase diagrams #2522

Merged
merged 2 commits into from May 14, 2022

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented May 13, 2022

JSON reconstruction bug:
The problem is: Because MSONables from_dict was replaced, there is no recursive reconstruction of the objects when you hit el_ref . When you do as_dict -> from_dict in python everything looks fine.
but the object was never completely serialized.
If you completely serialized it like putting it into as json file or database then you cannot reconstruct the phase diagram.

@coveralls
Copy link

coveralls commented May 13, 2022

Coverage Status

Coverage decreased (-0.7%) to 83.324% when pulling bb87db4 on jmmshn:pd_fix into 8a78794 on materialsproject:master.

@mkhorton
Copy link
Member

Thanks @jmmshn!

@mkhorton mkhorton merged commit 9c96ee0 into materialsproject:master May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants