Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of pre-commit hook settings for pylint #2496

Merged
merged 2 commits into from Apr 19, 2022

Conversation

lan496
Copy link
Contributor

@lan496 lan496 commented Apr 16, 2022

Improvement of settings for pylint in .pre-commit-config.yaml, continuation of #2492 (@janosh, thank you for telling me the snippet!)

  • I have confirmed pylint is now automatically installed when pre-commit hooks are called.
  • Adding instructions to set up optional dependencies in docs.

@lan496 lan496 changed the title Improvement of pre-commit hook settings for pylint [WIP]Improvement of pre-commit hook settings for pylint Apr 16, 2022
@coveralls
Copy link

coveralls commented Apr 16, 2022

Coverage Status

Coverage decreased (-0.7%) to 83.272% when pulling 0aacddd on lan496:pylint-hook into 827ad4e on materialsproject:master.

@janosh
Copy link
Member

janosh commented Apr 16, 2022

Oops, looks like pylint is too slow for pre-commit.ci (timeout after 180 seconds). I guess it needs to be skipped after all.

@lan496
Copy link
Contributor Author

lan496 commented Apr 17, 2022

I have restored to skip pylint in pre-commit.ci due to the timeout limitation.
I believe it is ready to be merged after all other tests are passed!

@lan496 lan496 changed the title [WIP]Improvement of pre-commit hook settings for pylint Improvement of pre-commit hook settings for pylint Apr 17, 2022
@shyuep shyuep merged commit f65dd5c into materialsproject:master Apr 19, 2022
@lan496 lan496 deleted the pylint-hook branch April 20, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants