Clean up tests #2495
Merged
Clean up tests #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_expansion_coeff() plus lots of F841 local variable 'foo' is assigned to but never used
|
Hey, just say your comment for the lobster tests. I think I forgot to include one assertion... Could you add "self.assertEqual(icooplist_bise, self.icoop_bise.icohplist)" to line 621 of test_lobster.py? I think this should work. Otherwise, I will put this on my ToDo. |
fixes flake8 F841 unused variable
|
@JaGeo Wow, you spotted that TODO quickly! 😄 Thanks, I added your code snippet. |
|
Thanks 🙂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boring part of this PR: Fix some flake8 violations.
Worth reviewing are changes to
PathFinderTest.test_image_num()ElasticTensorExpansionTest.test_thermal_expansion_coeff()