Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup LammpsData.as_string; add as_lammpsdata method to CombinedData #2132

Merged
merged 8 commits into from
May 5, 2021
Merged

Speedup LammpsData.as_string; add as_lammpsdata method to CombinedData #2132

merged 8 commits into from
May 5, 2021

Conversation

htz1992213
Copy link
Contributor

Summary

Include a summary of major changes in bullet points:

  • Speedup LammpsData.as_string for non-hybrid data with large coeff sections
  • Add as_lammpsdata method to CombinedData which allows CombinedData object to be converted to its superclass

@coveralls
Copy link

coveralls commented May 3, 2021 •
edited

Coverage Status

Coverage decreased (-0.6%) to 83.018% when pulling e11261e on htz1992213:master into ce2fb4e on materialsproject:master.

@shyuep
Copy link
Member

shyuep commented May 4, 2021

Thanks. Can you add a unittest for the new method pls?

@htz1992213
Copy link
Contributor Author

Thanks. Can you add a unittest for the new method pls?

I have added the tests accordingly. Thanks!

@shyuep
Copy link
Member

shyuep commented May 5, 2021

THanks!

@shyuep shyuep merged commit 2ef73af into materialsproject:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@htz1992213 @coveralls @shyuep