Ensure all MP2020 corrections have unique names; tweak oxi state detection #2130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that energy corrections applied to each anion have unique names (e.g., N vs. Cl vs. Br).
If this is not the case, then in a compound with multiple corrected anions like
C2NCl
,Compatibility
will apply a correction to the first anion, then think the second is a duplicate, warningAlso makes some tweaks to oxidation state detection to work better with the Builders.