Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2118 Stop MP2020Corrections saving hardcoded path #2124

Merged
merged 1 commit into from
May 3, 2021
Merged

#2118 Stop MP2020Corrections saving hardcoded path #2124

merged 1 commit into from
May 3, 2021

Conversation

CompRhys
Copy link
Contributor

resolves #2118 by leaving config path as None if custom path not given. Raises ValueError is a custom path given but the file does not exist.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 83.013% when pulling ce45ed3 on CompRhys:master into cb9854d on materialsproject:master.

@mkhorton mkhorton merged commit 7ab93bd into materialsproject:master May 3, 2021
@mkhorton
Copy link
Member

mkhorton commented May 3, 2021

Thanks for the fix @CompRhys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Hard-Coded path when using MontyEncoder/Decoder for MP2020Compat
3 participants
@CompRhys @coveralls @mkhorton