Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoLike groupby ignore sort, skip, limit kwargs; confusing properties behavior #622

Open
rkingsbury opened this issue Apr 11, 2022 · 0 comments · May be fixed by #670
Open

MongoLike groupby ignore sort, skip, limit kwargs; confusing properties behavior #622

rkingsbury opened this issue Apr 11, 2022 · 0 comments · May be fixed by #670

Comments

@rkingsbury
Copy link
Collaborator

rkingsbury commented Apr 11, 2022

Thanks to clever synatx highlighting in my code editor, I noticed that the kwargs sort, skip, and limit that are shown for MongoStore.groupby and MemoryStore.groupby appear to be non-functional.

These kwargs should be made functional (preferably, if it makes sense) or removed.

Related - it is not clear to me why the groupby methods for MongoStore and MemoryStore need to be different, since MemoryStore is designed to emulate MongoStore in every respect. If MemoryStore could inherit MongoStore's groupby that would be more robust (and prevent subtle bugs like the one described in #621 ).

Related #2 - MemoryStore.groupby does not return any data unless you explicitly pass fields to properties. This may affect other MongoLike stores, too but I'm not sure. See discussion here.

I may investigate this at a later time but would welcome comments from better-informed developers!

@rkingsbury rkingsbury changed the title MongoLike groupby ignore sort, skip, limit kwargs MongoLike groupby ignore sort, skip, limit kwargs; confusing properties behavior May 27, 2022
@rkingsbury rkingsbury linked a pull request May 27, 2022 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant