Skip to content

Feature request - adding state of the FW for _pass_job_info #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

mhsiron
Copy link
Contributor

@mhsiron mhsiron commented Jul 30, 2019

For the special spec argument "_pass_job_info", it would be useful to get the state of the parent FWs. Normally, the state of a parent should be "COMPLETED", however, if we also have the special spec argument "_allow_fizzled_parents" this is not always the case. It would be easier to pass the job info for this situation than to load it from the collection during a FW.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
For the special spec argument "_pass_job_info", it would be useful to get the state of the parent FWs. Normally, the state of a parent should be "COMPLETED", however, if we also have the special spec argument "_allow_fizzled_parents" this is not always the case. It would be easier to pass the job info for this situation than to load it from the collection during a FW.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.717% when pulling 4617fba on mhsiron:patch-1 into 1d25850 on materialsproject:master.

@computron computron merged commit 7b519dd into materialsproject:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants