Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Use a uniform way to update labels #4093

Closed
wants to merge 1 commit into from
Closed

[Slider] Use a uniform way to update labels #4093

wants to merge 1 commit into from
+33 −30

Conversation

pubiqq
Copy link
Contributor

@pubiqq pubiqq commented Mar 7, 2024

Also fixes #4090

@pekingme pekingme self-assigned this Mar 7, 2024
@pekingme pekingme self-requested a review March 7, 2024 18:26
pekingme
pekingme approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@pekingme pekingme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Port for internal reviews.

@pekingme pekingme added the Reviewing Internally An internal change has been created and sent for review. label Mar 7, 2024
hunterstich pushed a commit that referenced this pull request Mar 21, 2024
@pubiqq @hunterstich
[Slider] Use a uniform way to update labels
884465b 
Resolves #4093

GIT_ORIGIN_REV_ID=7db4936713bd31a070d4bb1d9743d99222840184
PiperOrigin-RevId: 614741678

(cherry picked from commit 3bc6612)
tribalfs pushed a commit to tribalfs/sesl-material-components-android that referenced this pull request Mar 25, 2024
@pubiqq @tribalfs
[Slider] Use a uniform way to update labels
a81690f 
Resolves material-components#4093

GIT_ORIGIN_REV_ID=7db4936713bd31a070d4bb1d9743d99222840184
PiperOrigin-RevId: 614741678

(cherry picked from commit 3bc6612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekingme pekingme pekingme approved these changes

Assignees

@pekingme pekingme

Labels
Reviewing Internally An internal change has been created and sent for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Slider] Incorrect slider label behavior inside ViewPager
2 participants
@pubiqq @pekingme