Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create abstraction over search_after for pagination #4

Open
Radiergummi opened this issue Feb 11, 2021 · 2 comments
Open

Create abstraction over search_after for pagination #4

Radiergummi opened this issue Feb 11, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Radiergummi
Copy link
Member

Elasticsearch recommends using search_after instead of the scroll API for pagination. Using it requires lots of knowledge about Elasticsearch though, and it's quite cumbersome currently.
We should provide a simple wrapper for this new pagination API.
@Radiergummi Radiergummi added enhancement New feature or request good first issue Good for newcomers labels Feb 11, 2021
@chai-masalla
Copy link

@Radiergummi Hi

I added PIT mechanism as part of this issue, how can I push it?

@Radiergummi
Copy link
Member Author

Hi @chai-masalla, I'd be very much interested in this!

To add your changes, please follow the contribution guide by GitHub, and I will review and merge the PIT feature. Excited to have this in the library 🙂

@chai-masalla chai-masalla mentioned this issue Sep 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Radiergummi @chai-masalla