Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel dependencies #1

Open
Radiergummi opened this issue Nov 11, 2020 · 0 comments
Open

Laravel dependencies #1

Radiergummi opened this issue Nov 11, 2020 · 0 comments
Assignees
@Radiergummi
Labels
enhancement New feature or request heritage Heritage from the original library that should be sorted out

Comments

@Radiergummi
Copy link
Member

Currently, the library has dependencies on Laravel code in several places, making it essentially incompatible with "any other application using composer" or even Lumen, I think. However, the dependent code seems to not fully work as intended (eg. pagination link resolution).
We should either fully embrace Laravel, introduce proper abstractions and fix the code, or throw out all framework-specific code and remain compatible with other applications. The former would be faster, but reduce reusability, the latter would be harder, but result in a versatile library we could use in other projects, too.
@Radiergummi Radiergummi added enhancement New feature or request heritage Heritage from the original library that should be sorted out labels Nov 11, 2020
@Radiergummi Radiergummi self-assigned this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Radiergummi Radiergummi

Labels
enhancement New feature or request heritage Heritage from the original library that should be sorted out
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Radiergummi