From 1df16109c96a4aa27745ce93411a8cc67ae42321 Mon Sep 17 00:00:00 2001 From: Tharaka Wijebandara Date: Sat, 2 Sep 2017 01:24:58 +0530 Subject: [PATCH 01/19] Fix error overlay 'Object.assign' issue in IE by including polyfills before webpack client (#3046) --- packages/react-scripts/config/webpack.config.dev.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/config/webpack.config.dev.js b/packages/react-scripts/config/webpack.config.dev.js index 3ef1104a177..90d6a641322 100644 --- a/packages/react-scripts/config/webpack.config.dev.js +++ b/packages/react-scripts/config/webpack.config.dev.js @@ -43,6 +43,8 @@ module.exports = { // This means they will be the "root" imports that are included in JS bundle. // The first two entry points enable "hot" CSS and auto-refreshes for JS. entry: [ + // We ship a few polyfills by default: + require.resolve('./polyfills'), // Include an alternative client for WebpackDevServer. A client's job is to // connect to WebpackDevServer by a socket and get notified about changes. // When you save a file, the client will either apply hot updates (in case @@ -54,8 +56,6 @@ module.exports = { // require.resolve('webpack-dev-server/client') + '?/', // require.resolve('webpack/hot/dev-server'), require.resolve('react-dev-utils/webpackHotDevClient'), - // We ship a few polyfills by default: - require.resolve('./polyfills'), // Finally, this is your app's code: paths.appIndexJs, // We include the app code last so that if there is a runtime error during From 270b1dc5cd2dc324de4f5f45145e679548fd5080 Mon Sep 17 00:00:00 2001 From: "Erik J. Sturcke" Date: Fri, 1 Sep 2017 15:56:17 -0400 Subject: [PATCH 02/19] Strip hash from chunk file name (#3049) --- packages/react-dev-utils/FileSizeReporter.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/react-dev-utils/FileSizeReporter.js b/packages/react-dev-utils/FileSizeReporter.js index ab9a2728752..f25e473787d 100644 --- a/packages/react-dev-utils/FileSizeReporter.js +++ b/packages/react-dev-utils/FileSizeReporter.js @@ -92,7 +92,10 @@ function printFileSizesAfterBuild( function removeFileNameHash(buildFolder, fileName) { return fileName .replace(buildFolder, '') - .replace(/\/?(.*)(\.\w+)(\.js|\.css)/, (match, p1, p2, p3) => p1 + p3); + .replace( + /\/?(.*)(\.[0-9a-f]+)(\.chunk)?(\.js|\.css)/, + (match, p1, p2, p3, p4) => p1 + p4 + ); } // Input: 1024, 2048 From 51d0df490295b70808b61d780a54ebcf296a8db2 Mon Sep 17 00:00:00 2001 From: Tharaka Wijebandara Date: Sat, 2 Sep 2017 06:29:37 +0530 Subject: [PATCH 03/19] Rename Overlay to ErrorOvelay (#3051) --- .../src/components/{Overlay.js => ErrorOverlay.js} | 4 ++-- .../src/containers/CompileErrorContainer.js | 6 +++--- .../src/containers/RuntimeErrorContainer.js | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) rename packages/react-error-overlay/src/components/{Overlay.js => ErrorOverlay.js} (96%) diff --git a/packages/react-error-overlay/src/components/Overlay.js b/packages/react-error-overlay/src/components/ErrorOverlay.js similarity index 96% rename from packages/react-error-overlay/src/components/Overlay.js rename to packages/react-error-overlay/src/components/ErrorOverlay.js index 4fe530b6fee..446105dad2e 100644 --- a/packages/react-error-overlay/src/components/Overlay.js +++ b/packages/react-error-overlay/src/components/ErrorOverlay.js @@ -31,7 +31,7 @@ const overlayStyle = { color: black, }; -class Overlay extends Component { +class ErrorOverlay extends Component { iframeWindow: window = null; getIframeWindow = (element: HTMLDivElement) => { @@ -71,4 +71,4 @@ class Overlay extends Component { } } -export default Overlay; +export default ErrorOverlay; diff --git a/packages/react-error-overlay/src/containers/CompileErrorContainer.js b/packages/react-error-overlay/src/containers/CompileErrorContainer.js index bd193eb50b4..a3e89fe591d 100644 --- a/packages/react-error-overlay/src/containers/CompileErrorContainer.js +++ b/packages/react-error-overlay/src/containers/CompileErrorContainer.js @@ -9,7 +9,7 @@ /* @flow */ import React, { PureComponent } from 'react'; -import Overlay from '../components/Overlay'; +import ErrorOverlay from '../components/ErrorOverlay'; import Footer from '../components/Footer'; import Header from '../components/Header'; import CodeBlock from '../components/CodeBlock'; @@ -19,11 +19,11 @@ class CompileErrorContainer extends PureComponent { render() { const { error } = this.props; return ( - +

To get started, edit src/App.js and save to reload.