Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't execute SC on M1 Mac #79

Closed
qdrn opened this issue Jan 17, 2022 · 5 comments · Fixed by #97
Closed

Can't execute SC on M1 Mac #79

qdrn opened this issue Jan 17, 2022 · 5 comments · Fixed by #97
Assignees
Labels
bug Something isn't working

Comments

@qdrn
Copy link
Member

qdrn commented Jan 17, 2022

Currently the singlepass compiler does not work with M1 Macs (https://docs.wasmer.io/ecosystem/wasmer/wasmer-features#compiler-support-by-chipset).

See also: https://github.com/massalabs/massa/discussions/2067#discussioncomment-1942107

This issue is blocked by wasmerio/wasmer#2463

Maybe there is a way to contribute upstream ? All Mac are expected to switch to M1 in the near future.

@damip damip added the bug Something isn't working label Jan 17, 2022
@damip
Copy link
Member

damip commented Jan 17, 2022

Could we try to go hand in hand with Near and Wasmer to solve this problem more quickly, all together ?

@mandrean
Copy link

They are already working on it and close to done, see wasmerio/wasmer#2750

@damip
Copy link
Member

damip commented Feb 7, 2022

merged upstream. Let's bump the wasmer version in massa

@qdrn
Copy link
Member Author

qdrn commented Feb 7, 2022

I can confirm it's working with the latest version of wasmer. I had to make the following changes:

wasmer = "2.2.0-rc1"
wasmer-compiler-singlepass = "2.2.0-rc1"
wasmer-engine-universal = "2.2.0-rc1"
wasmer-middlewares = "2.2.0-rc1"

and also update wasmer in the as-ffi-bindings crate.

@damip
Copy link
Member

damip commented Feb 7, 2022

can someone open a PR for this ?

@qdrn qdrn linked a pull request Feb 7, 2022 that will close this issue
@bors bors bot closed this as completed in #97 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants