From b596237f3ecf5d9d1ed34b3eda813b4a8ba7bfe8 Mon Sep 17 00:00:00 2001 From: Martin Jesper Low Madsen Date: Wed, 1 Jul 2020 20:39:43 +0200 Subject: [PATCH] fix(plugin-version): Correctly check void releases for a null value js-yaml implements the YAML spec and it has no undefined type: - https://github.com/nodeca/js-yaml/issues/356#issuecomment-311614322 I.e.: ``` > require('js-yaml').safeLoad('releases:\n') { releases: null } ``` --- .yarn/versions/7bfd08a0.yml | 2 ++ packages/plugin-version/sources/versionUtils.ts | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 .yarn/versions/7bfd08a0.yml diff --git a/.yarn/versions/7bfd08a0.yml b/.yarn/versions/7bfd08a0.yml new file mode 100644 index 000000000000..a10256495695 --- /dev/null +++ b/.yarn/versions/7bfd08a0.yml @@ -0,0 +1,2 @@ +releases: + "@yarnpkg/plugin-version": prerelease diff --git a/packages/plugin-version/sources/versionUtils.ts b/packages/plugin-version/sources/versionUtils.ts index 9901ac781c93..1ef6607d78bc 100644 --- a/packages/plugin-version/sources/versionUtils.ts +++ b/packages/plugin-version/sources/versionUtils.ts @@ -174,7 +174,7 @@ export async function updateVersionFiles(project: Project) { const versionContent = await xfs.readFilePromise(versionPath, `utf8`); const versionData = parseSyml(versionContent); - if (typeof versionData.releases === `undefined`) + if (versionData.releases === null) continue; for (const locatorStr of Object.keys(versionData.releases || {})) {