Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make schema class configurable #376

Merged
merged 3 commits into from
Mar 16, 2019
Merged

Make schema class configurable #376

merged 3 commits into from
Mar 16, 2019

Conversation

ThiefMaster
Copy link
Contributor

No description provided.

This was referenced Mar 15, 2019
Closed
Merged
sloria
sloria approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR. I just renamed "schema_cls" to "schema_class" because there's no reason to abbreviate "cls" in this case, and it's more consistent with, e.g. OPTIONS_CLASS.

@sloria sloria merged commit c60472b into marshmallow-code:dev Mar 16, 2019
@ThiefMaster ThiefMaster deleted the customizable-schema branch March 16, 2019 20:54
@sloria
Copy link
Member

sloria commented Jul 23, 2019

For anyone finding this... there's a proposal for adding this "dict-to-schema" behavior into marshmallow core: marshmallow-code/marshmallow#1312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloria sloria sloria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThiefMaster @sloria