Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

ModelSerializer support? #15

Open
mustaqeem opened this issue Oct 7, 2017 · 4 comments
Open

ModelSerializer support? #15

mustaqeem opened this issue Oct 7, 2017 · 4 comments

Comments

@mustaqeem
Copy link

Is there any support for ModelSerializer?

It is useless to define all the fields again in the Schema.

@sloria
Copy link
Member

sloria commented Dec 8, 2017

ModelSerializer is not currently supported. I would certainly review and merge a PR adding it though =)

@mickyginger
Copy link

I'd like to have a go at this, but I am very new to Python, Django and Marshmallow o_O

However, would I be correct in thinking implementing it would be along the lines of the marshmallow-sqlalchemy ModelSchema implementation? https://github.com/marshmallow-code/marshmallow-sqlalchemy/blob/dev/src/marshmallow_sqlalchemy/schema.py

There are no contributing guidelines for this repo, but can I assume they are the same as the marshmallow_sqlalchemy ones? https://github.com/marshmallow-code/marshmallow-sqlalchemy/blob/dev/CONTRIBUTING.rst

@sloria
Copy link
Member

sloria commented Aug 18, 2019

Thanks for offering to work on this! Yes, I think it will look along the lines of marshmallow-sqlalchemy. It's probably also worth looking at the implementation of ModelSerializer in DRF.

The contributing guidelines for this project should match the other marshmallow libs.

@faridelnasire
Copy link

I'd highly appreciate this as well!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants