nwalfield's streaming reader #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 95.85% 95.93% +0.08%
==========================================
Files 12 14 +2
Lines 1447 1699 +252
==========================================
+ Hits 1387 1630 +243
- Misses 60 69 +9
Continue to review full report at Codecov.
|
Merged
Turns out the initial, simple implementation didn't handle cases where slow or otherwise unpredictable delegate `Read`ers wouldn't provide as many bytes as we asked for, which meant there has to be a lot more bookkeeping. Also, only one nontrivial buffer is needed now.
|
@nwalfield take a look when you get a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #106.