Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise that unsafe code is forbidden #116

Merged
merged 1 commit into from Sep 11, 2019

Conversation

Shnatsel
Copy link
Contributor

@Shnatsel Shnatsel commented Sep 7, 2019

Having zero unsafe code and forbidding it is a desirable property for Rust code. This commit adds a badge to advertise this property. This helps users make a more informed choice when picking a crate for base64 encoding/decoding.

In this PR clicking the badge leads to the Rust Secure Code WG coordination repo for removing unnecessary unsafe code from the Rust ecosystem. I'm fine with making the link lead somewhere else or making the badge non-clickable if you prefer.

Having zero unsafe code and forbidding it is a desirable property for Rust code. This commit adds a badge to advertise this property. This helps users make a more informed choice when picking a base64 crate.

In this PR clicking the badge leads to the Rust Secure Code WG coordination repo for removing unnecessary unsafe code from the Rust ecosystem. I'm fine with making the link lead somewhere else or making the badge non-clickable if you prefer.
@codecov-io
Copy link

codecov-io commented Sep 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a40d420). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #116   +/-   ##
=========================================
  Coverage          ?   95.89%           
=========================================
  Files             ?       12           
  Lines             ?     1461           
  Branches          ?        0           
=========================================
  Hits              ?     1401           
  Misses            ?       60           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40d420...85623ca. Read the comment docs.

@marshallpierce
Copy link
Owner

LGTM, thank you!

@marshallpierce marshallpierce merged commit 9ae0292 into marshallpierce:master Sep 11, 2019
@Shnatsel Shnatsel deleted the patch-1 branch September 11, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants