-
Notifications
You must be signed in to change notification settings - Fork 90
add setting to only create, but not update comment #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
output of yarn all
|
index.js has still changed a lot because of dependency updates / not using a lock file. There is the yarn.lock file, but I'm not sure what it's doing, it's just getting updated locally with a bunch of quotes around all kinds of values and I chose not to check it in. |
I will add index.js in |
It tagged as v2.4.0, v2. Thank you. |
for index.js it's important it's kept updated because that's what's actually going to be run on the github action. If you decide to omit the dist folder, you need to have a separate branch or individual separate commits that have the dist folder contained with CI generated index.js I think package-lock.json should just be checked in, so when running |
note: generated dist/*.js files diff seems to contain a little more, probably due to differing dependencies. It might make sense to check in the package-lock.json file to prevent this from happening when installing the node modules.
Example use-case: