Years below 100 not allowed?

[donaldpipowitch]

Hi! Not sure if this is a bug or "intended"/due to some date quirks, but I can't use a year below 100.

zonedTimeToUtc('0100-01-01', 'Europe/Berlin').toISOString()
// === "0099-12-31T23:06:32.000Z"

zonedTimeToUtc('0099-01-01', 'Europe/Berlin').toISOString()
// === "-001801-01-01T23:06:32.000Z"

[marnusw]

Certainly not intentional. I can't guarantee that I'll be able to look at this any time soon since it seems like quite an edge case. I'd welcome a PR though. You can also check the date-fns library directly to see if they support it, because the toDate function was copied from date-fns some versions ago.

[donaldpipowitch]

Thanks for the quick reply.

[make-github-pseudonymous-again]

This bug probably stems from the Date constructor.

[make-github-pseudonymous-again]

Note that there used to be a similar bug in date-fns but it has been fixed a long time ago (November 2016).

[make-github-pseudonymous-again]

I get the following output on runkit (date-fnsv2.28.0, date-fns-tzv1.3.0):

zonedTimeToUtc('0099-01-01', 'Europe/Berlin').toISOString()
"1998-12-31T23:00:00.000Z"

[make-github-pseudonymous-again]

Just wrote a draft PR #170 fixing this issue.

[marnusw]

Released in v1.3.2.

[marnusw]

Thanks, will take a look as soon as I can.

…

On Wed, 9 Mar 2022, 12:49 Notas Hellout, ***@***.***> wrote: Just wrote a draft PR #170 <#170> fixing this issue. — Reply to this email directly, view it on GitHub <#87 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHNF27QDI5SZDJXS7QESKDU7B62PANCNFSM4SHFNJUA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>