Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Compatibility with setDefaultOptions in date-fns #233

Open
lnunno opened this issue Apr 13, 2023 · 2 comments · May be fixed by #286
Open

Feature request: Compatibility with setDefaultOptions in date-fns #233

lnunno opened this issue Apr 13, 2023 · 2 comments · May be fixed by #286

Comments

@lnunno
Copy link

lnunno commented Apr 13, 2023

I'm not sure if this is expected to work, but I'm not seeing the options being passed into setDefaultOptions being respected by this library and instead have to pass in the options to each function call, for example formatInTimeZone needs the locale specified and doesn't use the one provided in setDefaultOptions
@marnusw
Copy link
Owner

marnusw commented Apr 14, 2023

You're right, it's not respected. I was either not aware of that function in date-fns or it's fairly new to be honest. Happy to support that though. I'll leave this open for when I have time or would be happy looking at a PR.

@ArianHamdi
Copy link

This is really helpful.

@yangchristina yangchristina linked a pull request May 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compatibility with setDefaultOptions in date-fns yangchristina/date-fns-tz
3 participants
@marnusw @lnunno @ArianHamdi