Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update format types to match date-fns #199

Merged
merged 1 commit into from Jan 24, 2023
Merged

fix: update format types to match date-fns #199

merged 1 commit into from Jan 24, 2023

Conversation

bmeverett
Copy link
Contributor

Fixes #198

Updates the types for format from date-fns to accept Date | Number and removes string.

@bmeverett
Copy link
Contributor Author

@marnusw are you able to take a look at this. Not sure about the failing tests.

@marnusw marnusw merged commit 9fe0964 into marnusw:master Jan 24, 2023
@marnusw
Copy link
Owner

marnusw commented Jan 24, 2023

Thank you. I'm sorry it took me forever to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update types for format to match date-fns
2 participants
@bmeverett @marnusw