Add new to DateTimeFormat invocation #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we mock
Intl.DateTimeFormat
in order to quickly run tests against various timezones. I understand your preferred method differs, but this had been working for us up to version1.1.4
quite nicely.In 1.1.5 a commit introduced
isValidTimezoneIANAString
which invokesIntl.DateTimeFormat
withoutnew
. When mocking, this causes the errorUncaught TypeError: Class constructor DateTimeFormatFake cannot be invoked without 'new'
which subsequently causes anInvalid Date
error. The fix is as simple as addingnew
, which shouldn't affect anyone who isn't mocking, but may help those who would like to.