feat: add disable options to SelectArrayInput #5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Feb 24, 2021
examples/demo/src/segments/data.ts
Outdated
| @@ -4,5 +4,9 @@ export default [ | |||
| { id: 'ordered_once', name: 'resources.segments.data.ordered_once' }, | |||
| { id: 'regular', name: 'resources.segments.data.regular' }, | |||
| { id: 'returns', name: 'resources.segments.data.returns' }, | |||
| { id: 'reviewer', name: 'resources.segments.data.reviewer' }, | |||
There was a problem hiding this comment.
Please revert this change, and use the simple example to illustrate the functionality. Here, it makes the e-commerce demo worse for no reason.
| @@ -17,6 +17,7 @@ const SegmentsInput: FC<Props> = ({ addField, ...rest }) => { | |||
| choices={segments.map(segment => ({ | |||
| id: segment.id, | |||
| name: translate(segment.name), | |||
| disabled: segment.disabled, | |||
commit 8d8e3f7 Author: Paulo Viana <paulo9mv@yahoo.com.br> Date: Sat Feb 20 15:45:13 2021 -0400 feat: add documentation commit fce1306 Author: Paulo Viana <paulo9mv@yahoo.com.br> Date: Sat Feb 20 13:28:33 2021 -0400 feat: add disableValue prop to useChoices commit 0db4dba Author: Paulo Viana <paulo9mv@yahoo.com.br> Date: Sat Feb 20 11:21:00 2021 -0400 feat: add disabled selectArrayInput unit test commit 1c1f7a8 Author: Paulo Viana <paulo9mv@yahoo.com.br> Date: Fri Feb 19 08:33:51 2021 -0400 feat: remove optionDisable commit 03a88a8 Author: Paulo Viana <paulo9mv@yahoo.com.br> Date: Fri Feb 19 08:31:48 2021 -0400 feat: add disabled option to menuItem commit ab59e72 Author: Paulo Viana <paulo9mv@yahoo.com.br> Date: Thu Feb 18 23:31:31 2021 -0400 feat: add disabled choices to selectArrayInput
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
paulo9mv
force-pushed
the
disable-select-array-input-options
branch
from
61f53f7
to
2d55102
Compare
fzaninotto
approved these changes
Feb 26, 2021
|
Thanks! |
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add disabled options to
SelectArrayInputas discussed in the issue #5759