Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase markedjs to latest version #1155

Closed
fxha opened this issue Jul 15, 2019 · 7 comments
Closed

Rebase markedjs to latest version #1155

fxha opened this issue Jul 15, 2019 · 7 comments
Assignees
@fxha
Labels
🐸 markdown/spec Issue related to markdown specification
Projects
0.16.0

Comments

@fxha
Copy link
Contributor

fxha commented Jul 15, 2019

Issue to track the rebase of markedjs v0.7.0 - current marked version is 0.6.2. The new version contains inline style fixes but also two security fixes.
@fxha fxha added this to To do in v0.15.x Jul 15, 2019
@Jocs
Copy link
Member

Jocs commented Jul 22, 2019

@fxha I think this issue should be placed at 0.16.0, because rebase marked is a tedious job and it takes a long time to test?

@Jocs Jocs removed this from To do in v0.15.x Jul 22, 2019
@Jocs Jocs added this to TO-DO in 0.16.0 Jul 22, 2019
@fxha
Copy link
Contributor Author

fxha commented Jul 22, 2019

I think we should pick the two security fixes and add further changes in v0.16.0.

@Jocs
Copy link
Member

Jocs commented Jul 22, 2019

the two security fixes

Which two fixes?

@fxha
Copy link
Contributor Author

fxha commented Jul 22, 2019

These two:

- Sanitize paragraph and text tokens #1504
- Fix ReDOS for links with backticks (issue #1493) #1515

@Jocs
Copy link
Member

Jocs commented Jul 23, 2019

@fxha markedjs/marked#1504 (comment) is tolerated at current time, because we already sanitized the html in export html and preview html.

and I'll rebase #1515.

@fxha fxha added the 🐸 markdown/spec Issue related to markdown specification label Aug 4, 2019
@fxha fxha moved this from TO-DO to In Progress in 0.16.0 Sep 25, 2019
@fxha fxha self-assigned this Sep 25, 2019
@Jocs Jocs moved this from In Progress to Review in 0.16.0 Sep 27, 2019
@Jocs
Copy link
Member

Jocs commented Sep 29, 2019

@fxha Did you finish this issue? Can we close it now?

1 similar comment
@Jocs
Copy link
Member

Jocs commented Sep 29, 2019

@fxha Did you finish this issue? Can we close it now?

@fxha fxha closed this as completed Sep 29, 2019
@Jocs Jocs moved this from Review to Done in 0.16.0 Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxha fxha

Labels
🐸 markdown/spec Issue related to markdown specification
Projects
No open projects
0.16.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jocs @fxha