Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly modal #57

Open
john-theo opened this issue Oct 4, 2019 · 6 comments
Open

Ugly modal #57

john-theo opened this issue Oct 4, 2019 · 6 comments
Assignees
Milestone

Comments

@john-theo
Copy link
Collaborator

  1. 不喜欢modal,偏好两种方案:A. 放进dropdown;B. 左半边编辑器被换成选择
  2. 丑陋!请有一点对齐和交互!我用了之前我写的Color,勉强凑合
  3. 希望新增每套主题的封面效果图
@john-theo john-theo added this to the v1.0 milestone Oct 4, 2019
@awmleer
Copy link
Member

awmleer commented Oct 4, 2019

modal的美观问题,我觉得交给用户去评判,这个issue先保留在这里,如果后续还有很多人反馈的话,我们再去改吧。

从逻辑上讲,modal的确是最清晰的,从美观上来说的话,我觉得是完全OK的。。

@awmleer
Copy link
Member

awmleer commented Oct 4, 2019

我觉得强行避免使用modal非常不合理,每个组件都有它存在的价值,现在的modal因为实现简单的确没什么交互和样式,我觉得可以改进一下;但是我并不认同把本来非常适合用modal实现的逻辑强行“去modal化”。

@awmleer
Copy link
Member

awmleer commented Oct 4, 2019

至于第三点,v1 alpha版本暂时没bandwidth去做,后面有空了肯定会加上。

@john-theo
Copy link
Collaborator Author

即使再简陋,还是要满足设计原则的,我出稿子吧,你尽量复现克?

@awmleer
Copy link
Member

awmleer commented Oct 5, 2019 via email

@awmleer
Copy link
Member

awmleer commented Oct 11, 2019

@john-theo 所以稿子嘞?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants