Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always output no-update fragment on the server #1498

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

DylanPiercey
Copy link
Contributor

Description

This fixes an issue where no-update can cause the structure to change in a browser vs a server render causing some SSR'd dom to be incorrectly removed. Now we always output fragment markers for SSR'd no-update content to maintain a consistent structure.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #1498 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1498      +/-   ##
=========================================
- Coverage    90.5%   90.5%   -0.01%     
=========================================
  Files         352     352              
  Lines       12586   12583       -3     
=========================================
- Hits        11391   11388       -3     
  Misses       1195    1195
Impacted Files Coverage Δ
src/core-tags/components/preserve-tag.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebcea2...9fd46e7. Read the comment docs.

@DylanPiercey DylanPiercey merged commit aae3382 into master Feb 10, 2020
@DylanPiercey DylanPiercey deleted the preserve-tag-fragment-ssr branch February 26, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant