From d55fc105ca473942fdd061482ab0faf146bb0ea6 Mon Sep 17 00:00:00 2001 From: Tony Brix Date: Thu, 5 Dec 2019 11:27:44 -0600 Subject: [PATCH 1/2] fix changing global defaults --- src/defaults.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/defaults.js b/src/defaults.js index 4ff3e5a9b3..8d0be95580 100644 --- a/src/defaults.js +++ b/src/defaults.js @@ -1,5 +1,3 @@ -let defaults = getDefaults(); - function getDefaults() { return { baseUrl: null, @@ -22,11 +20,11 @@ function getDefaults() { } function changeDefaults(newDefaults) { - defaults = newDefaults; + module.exports.defaults = newDefaults; } module.exports = { - defaults, + defaults: getDefaults(), getDefaults, changeDefaults }; From 630aaa65b5c17f7c0839cffe0344a6b62baf8b1f Mon Sep 17 00:00:00 2001 From: Tony Brix Date: Thu, 5 Dec 2019 11:45:07 -0600 Subject: [PATCH 2/2] add test --- test/unit/marked-spec.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/test/unit/marked-spec.js b/test/unit/marked-spec.js index 4145f73807..7e84949492 100644 --- a/test/unit/marked-spec.js +++ b/test/unit/marked-spec.js @@ -71,3 +71,12 @@ describe('Test paragraph token type', () => { expect(tokens[7].type).toBe('text'); }); }); + +describe('changeDefaults', () => { + it('should change global defaults', () => { + const { defaults, changeDefaults } = require('../../src/defaults'); + expect(defaults.test).toBeUndefined(); + changeDefaults({ test: true }); + expect(require('../../src/defaults').defaults.test).toBe(true); + }); +});