Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use paragraph token in blockquote in list #2671

Merged
merged 1 commit into from Dec 7, 2022
Merged

fix: use paragraph token in blockquote in list #2671

merged 1 commit into from Dec 7, 2022

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Nov 30, 2022

Marked version: 4.2.3

Description

blockquote content should be parsed as if it is top level markdown. This currently breaks in lists that are not loose.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Nov 30, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marked-website ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 7:11AM (UTC)

@UziTech UziTech mentioned this pull request Nov 30, 2022
Closed
@UziTech UziTech merged commit edc857c into markedjs:master Dec 7, 2022
@UziTech UziTech deleted the blockquote-top branch December 7, 2022 07:45
github-actions bot pushed a commit that referenced this pull request Dec 7, 2022
@semantic-release-bot
chore(release): 4.2.4 [skip ci]
f2f9969 
## [4.2.4](v4.2.3...v4.2.4) (2022-12-07)

### Bug Fixes

* loose list items are loose ([#2672](#2672)) ([df4eb0e](df4eb0e))
* remove quotes at the end of gfm autolink ([#2673](#2673)) ([697ac2a](697ac2a))
* use paragraph token in blockquote in list ([#2671](#2671)) ([edc857c](edc857c))
gmsgowtham added a commit to gmsgowtham/react-native-marked that referenced this pull request Dec 8, 2022
@gmsgowtham
test: update Markdown.spec.tsx.snap
23e475d 
ref: markedjs/marked#2671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

@davisjam davisjam Awaiting requested review from davisjam

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] Different blockquote lex result when nesting inside a list
2 participants
@UziTech @styfle