Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix marked.use with multiple args #2651

Merged
merged 1 commit into from Nov 20, 2022
Merged

fix: fix marked.use with multiple args #2651

merged 1 commit into from Nov 20, 2022

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Nov 12, 2022

Marked version: 4.2.2

Description

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Nov 12, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marked-website ✅ Ready (Inspect) Visit Preview Nov 12, 2022 at 7:39AM (UTC)

@UziTech
Copy link
Member Author

UziTech commented Nov 19, 2022

Any objections to merging this?

styfle
styfle approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thanks! 🎉

@UziTech UziTech merged commit 73a7bf5 into markedjs:master Nov 20, 2022
@UziTech UziTech deleted the merge-options branch November 20, 2022 16:06
github-actions bot pushed a commit that referenced this pull request Nov 20, 2022
@semantic-release-bot
chore(release): 4.2.3 [skip ci]
b430f8b 
## [4.2.3](v4.2.2...v4.2.3) (2022-11-20)

### Bug Fixes

* fix entity specs ([#2652](#2652)) ([36a2b63](36a2b63))
* fix link reference definitions specs ([#2654](#2654)) ([b7eea95](b7eea95))
* fix marked.use with multiple args ([#2651](#2651)) ([73a7bf5](73a7bf5))
* fix multiline setext headings ([#2655](#2655)) ([4aee878](4aee878))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

@davisjam davisjam Awaiting requested review from davisjam

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple extensions in marked.use() causing defaults being wrongly overrided
2 participants
@UziTech @styfle