Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change of leading tab in unordered list #2516

Closed
ErazerBrecht opened this issue Jun 27, 2022 · 2 comments · Fixed by #2679
Closed

Breaking change of leading tab in unordered list #2516

ErazerBrecht opened this issue Jun 27, 2022 · 2 comments · Fixed by #2679
Labels
category: lists L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue

Comments

@ErazerBrecht
Copy link

What pain point are you perceiving?.
When using 2 leading tabs in a list it starts seeing it as a code block. Which could make sense
But starting from 4.0.15 it also places them on another level which I really can't explain.

Marked has introduced this breaking change between version 4.0.13 & 4.0.14, and 4.0.15 makes it even worse.
Caused by #2434

Working example 4.0.13
Broken example 4.0.14
Even more broken example 4.0.15

Describe the solution you'd like
A solution where it keeps working as it used to. I checked GitHub and they seem to ignore the tabs.
CommonMark seems to agree this is wrong. Dillinger also ignores it.

@UziTech UziTech added L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue category: lists labels Jun 27, 2022
lasmil pushed a commit to lasmil/marked that referenced this issue Oct 10, 2022
- when using tabs in unordered lists, we should use pedantic set to true to obtain a flat list
- closes: markedjs#2516
@lasmil
Copy link

lasmil commented Oct 10, 2022

Hi @ErazerBrecht . I played with the example you provided and (I might be wrong) I found that if you use the option: pedantic = true, then you will get the expected response.

I created a PR as well which should add an example of pedantic being false or true with your example (I think it will be useful for anybody who encounters this scenario).

@ErazerBrecht
Copy link
Author

Hi @lasmil thx for that idea.
I'll see if I can test that option!

Sincerely,
Brecht

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: lists L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue
Projects
None yet
3 participants