Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use template literal on some few places #2419

Merged
merged 2 commits into from Apr 2, 2022

Conversation

jimmywarting
Copy link
Contributor

Marked version:

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

  • Fixes #### (if fixing a known issue; otherwise, describe issue using the following format)

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Mar 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

markedjs – ./

🔍 Inspect: https://vercel.com/markedjs-legacy/markedjs/CFgU86NbaCZqfQGXkATLkWZ3whcH
✅ Preview: https://markedjs-git-fork-jimmywarting-template-4757f4-markedjs-legacy.vercel.app

marked-website – ./

🔍 Inspect: https://vercel.com/markedjs/marked-website/2u5bcnM94nDNPu7CgFQR7PyPGSct
✅ Preview: https://marked-website-git-fork-jimmywarting-template-literals-markedjs.vercel.app

src/Renderer.js Outdated Show resolved Hide resolved
@calculuschild
Copy link
Contributor

Do template literals cause any noticeable slowdown?

@UziTech
Copy link
Member

UziTech commented Mar 30, 2022

I don't see any difference when running npm run bench on master or this PR.

Co-authored-by: Tony Brix <tony@brix.ninja>
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is much cleaner. 💯

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UziTech UziTech merged commit 3795476 into markedjs:master Apr 2, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

🎉 This PR is included in version 4.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants