Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken "Strong" transform #2280

Closed
Tiberiusss opened this issue Nov 11, 2021 · 1 comment · Fixed by #2627
Closed

Broken "Strong" transform #2280

Tiberiusss opened this issue Nov 11, 2021 · 1 comment · Fixed by #2627
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue

Comments

@Tiberiusss
Copy link

Marked version: 4.0.1

Describe the bug
if inside bold text from the right border there is an escaped square open bracket and there is a closing brace behind "**", then bold text is not recognized

To Reproduce

  1. Marked Demo
  2. CommonMark Demo

Expected behavior
image
@UziTech UziTech added category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue labels Nov 12, 2021
@calculuschild
Copy link
Contributor

calculuschild commented May 12, 2022 •
edited

This seems to be in conflict with the spec: https://spec.commonmark.org/0.30/#right-flanking-delimiter-run

Edit: Misread the spec. This indeed looks like valid markdown. I wonder if our backslash escapes are resulting in characters not being recognized as "punctuation".

@gibson042 gibson042 mentioned this issue Oct 27, 2022
Merged
5 tasks
UziTech pushed a commit that referenced this issue Nov 2, 2022
@gibson042
fix: Support escapes within emphasis (#2627)
377823a 
* fix: Support escapes within emphasis

...particularly right at the end.

Fixes #2280

* chore: realign comments with regexp alternatives

* test: Add HTML test for escapes within emphasis

* fix: Correct recognition and masking of escaped emphasis punctuation

* fix: Correct backslash fake-lookbehind
github-actions bot pushed a commit that referenced this issue Nov 2, 2022
@semantic-release-bot
chore(release): 4.2.1 [skip ci]
3d389d5 
## [4.2.1](v4.2.0...v4.2.1) (2022-11-02)

### Bug Fixes

* Support escapes within emphasis ([#2627](#2627)) ([377823a](377823a)), closes [#2280](#2280)
@calculuschild calculuschild mentioned this issue Jun 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Support escapes within emphasis gibson042/marked
3 participants
@UziTech @calculuschild @Tiberiusss