Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix gfm urls after link #2186

Merged
merged 2 commits into from Aug 23, 2021
Merged

fix: fix gfm urls after link #2186

merged 2 commits into from Aug 23, 2021

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Aug 23, 2021

Marked version: 3.0.0

Markdown flavor: GitHub Flavored Markdown

Description

inLink state is not reset after creating a link token so GFM auto-urls are not being tokenized as links.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Aug 23, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/ARmKXHY5iamifcEGafmK5WR59EL6
✅ Preview: https://markedjs-git-fork-uzitech-fix-autolink-markedjs.vercel.app

calculuschild
calculuschild approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@calculuschild calculuschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am constantly amazed at how we can be passing all the unit tests and yet something else always manages to break. 😓

Looks good to me!

@UziTech UziTech merged commit e03b5c1 into markedjs:master Aug 23, 2021
@UziTech UziTech deleted the fix-autolink branch August 23, 2021 18:47
github-actions bot pushed a commit that referenced this pull request Aug 23, 2021
@semantic-release-bot
chore(release): 3.0.1 [skip ci]
ce30ed4 
## [3.0.1](v3.0.0...v3.0.1) (2021-08-23)

### Bug Fixes

* fix gfm urls after link ([#2186](#2186)) ([e03b5c1](e03b5c1))
@UziTech
Copy link
Member Author

UziTech commented Aug 23, 2021

I am constantly amazed at how we can be passing all the unit tests and yet something else always manages to break. 😓

No such thing as 100% test coverage for regexes 😅

@github-actions
Copy link

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@calculuschild calculuschild calculuschild approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All URL links are broken after Markdown link
3 participants
@UziTech @styfle @calculuschild