Add a type property to the def tokenizer's return object
#2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/4w5nnEqsuVHCgKGHPEwGncfHwnVd |
|
@styfle @calculuschild would this be a breaking change? |
|
I don't see anything that would be breaking. I think adding information is usually ok; only if someone is depending on no type to detect def tokens but I doubt that is a common occurrence. LGTM. |
calculuschild
approved these changes
Apr 9, 2021
styfle
approved these changes
Apr 10, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2021
## [2.0.2](v2.0.1...v2.0.2) (2021-04-10) ### Bug Fixes * add type property on def token ([#2001](#2001)) ([009427f](009427f))
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks ! |
5 tasks
UziTech
pushed a commit
that referenced
this pull request
Apr 11, 2021
Hmm I think I modified the wrong file (`lib/marked.js`) in the previous PR (see #2001) , this should be the right one ! Sorry for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2000
Marked version:
2.0.1
Markdown flavor: all
Description
typemember for all nodes #2000Expectation
Markdown nodes all have a
typeproperty to ease working with the markdown tree.Result
defnodes do not have atypeproperty.What was attempted
Using
walkTokensin typescript, I have the need to discriminate between nodes; the https://www.npmjs.com/package/@types/marked package doesn't define atypemember for theDefinterface, seemingly because there is not one here either.Contributor
Committer
In most cases, this should be a different person than the contributor.