Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of startsWith and endsWith breaks IE11 #1876

Closed
jhildenbiddle opened this issue Dec 14, 2020 · 1 comment · Fixed by #1877, TheRealSyler/zephyr#12, vigenere23/gabio-markdown-transpiler#3 or vigenere23/gabio-design-svelte#7
Closed

Use of startsWith and endsWith breaks IE11 #1876

jhildenbiddle opened this issue Dec 14, 2020 · 1 comment · Fixed by #1877, TheRealSyler/zephyr#12, vigenere23/gabio-markdown-transpiler#3 or vigenere23/gabio-design-svelte#7
Labels
released

Comments

@jhildenbiddle
Copy link
Contributor

Marked version: 1.2.6 (not sure when change was introduced)

Describe the bug
The use of startsWith and endsWith in the source breaks IE11

To Reproduce

  1. Launch IE11
  2. Open Developer Tools
  3. Click on Console tab
  4. Visit https://docsify.js.org (which uses marked 1.2.6)
  5. Note error message

Expected behavior
Expected marked to continue to work in IE11 until support is officially dropped in a future major version.
@jhildenbiddle jhildenbiddle changed the title Use of startsWith and endsWith bread IE11 Use of startsWith and endsWith breaks IE11 Dec 14, 2020
jhildenbiddle added a commit to jhildenbiddle/marked that referenced this issue Dec 14, 2020
@jhildenbiddle
Replace use of startsWith and endsWith with regex
06eec11 
fix markedjs#1876
@jhildenbiddle jhildenbiddle mentioned this issue Dec 14, 2020
Merged
5 tasks
UziTech pushed a commit that referenced this issue Dec 15, 2020
@jhildenbiddle
fix: Replace use of startsWith and endsWith with regex for IE11 (#1877)
4fdde20 
fix #1876
github-actions bot pushed a commit that referenced this issue Dec 15, 2020
@semantic-release-bot
chore(release): 1.2.7 [skip ci]
8bb7f8b 
## [1.2.7](v1.2.6...v1.2.7) (2020-12-15)

### Bug Fixes

* Replace use of startsWith and endsWith with regex for IE11 ([#1877](#1877)) ([4fdde20](4fdde20)), closes [#1876](#1876)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 11, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
1 participant
@jhildenbiddle